Skip to content

Removed isMounted and added a state to track if the component is mounted #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed isMounted and added a state to track if the component is mounted #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Navigator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ var Navigator = React.createClass({
activeGesture: null,
pendingGestureProgress: null,
transitionQueue: [],
mounted: false
};
},

Expand Down Expand Up @@ -477,6 +478,7 @@ var Navigator = React.createClass({
},

componentDidMount: function() {
this.setState({mounted: true})
this._handleSpringUpdate();
this._emitDidFocus(this.state.routeStack[this.state.presentedIndex]);
this._enableTVEventHandler();
Expand Down Expand Up @@ -571,7 +573,7 @@ var Navigator = React.createClass({
* happening, we only set values for the transition and the gesture will catch up later
*/
_handleSpringUpdate: function() {
if (!this.isMounted()) {
if (!this.state.mounted) {
return;
}
// Prioritize handling transition in progress over a gesture:
Expand All @@ -595,7 +597,7 @@ var Navigator = React.createClass({
* This happens at the end of a transition started by transitionTo, and when the spring catches up to a pending gesture
*/
_completeTransition: function() {
if (!this.isMounted()) {
if (!this.state.mounted) {
return;
}

Expand Down