Remove node2nix from Typescript's Nix utilities #162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredponn
force-pushed
the
jared/typescript-remove-node2nix
branch
from
856bd4c to
d116f31
Compare
jaredponn
force-pushed
the
jared/typescript-remove-node2nix
branch
from
d116f31 to
fc3c3fd
Compare
jaredponn
force-pushed
the
jared/typescript-remove-node2nix
branch
from
fc3c3fd to
0fc8d17
Compare
jaredponn
commented
Dec 12, 2023
| # ``` | ||
| # So instead, we explicitly write out all the attribute names and what | ||
| # they are assigned to. | ||
| inherit (typescriptFlake) packages checks devShells; |
There was a problem hiding this comment.
Woo hoo, no more IFD so this works now :^)
bladyjoker
approved these changes
Dec 13, 2023
| @@ -0,0 +1,53 @@ | |||
| # Given a `package-lock.json`, grabs all packages as tarballs. | |||
There was a problem hiding this comment.
Can you state which npm versions have what you expect?
| buildPhase = '' | ||
| cp -r "$src" . | ||
| cp -r "$src/." . |
There was a problem hiding this comment.
Haha yes, cp is difficult
| # ``` | ||
| # So instead, we explicitly write out all the attribute names and what | ||
| # they are assigned to. | ||
| inherit (typescriptFlake) packages checks devShells; |
bladyjoker
reviewed
Dec 13, 2023
I suppose this really is just Unfortunately, I ended up not going with this, so I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, one can scan the
package-lock.jsonfor URLS of tarballs for dependencies, then fetch those tarballs in a nix derivation, and manually add them intonpm's cache. Then,npm installwill surprisingly manage to find everything in the cache without hitting the network.Future work
For now, this only supports grabbing things from the npm registry, and in the future we would like to support the complete set of allowed package-specs by
npm.Honestly, a better way forward would probably to cook up a proxy registry to the npm registry. override
npms.t. it always uses the proxy registry, and dump all the nix packages there. A brief glance suggests that https://verdaccio.org/ might be useful for this :^).