Skip to content

Compiler: TypeClass checks #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

Compiler: TypeClass checks #29

merged 2 commits into from
Jan 27, 2023

Conversation

bladyjoker
Copy link
Contributor

@bladyjoker bladyjoker commented Jan 26, 2023 •
edited
Loading

DONE

  • Supers cycle check
  • Tests

Continuation from #27

TODOs

  • The cycle check should yield an API error, add a super class cycle error to the compiler.proto
  • The cycle check doesn't need to be performed separately, this can be done as you check for Class signatures which is essential.
  • The API for the ClassDef is not appropriate, we should change it in several ways.

@bladyjoker bladyjoker added enhancement New feature or request compiler Work related to the Lambda Buffers Compiler labels Jan 26, 2023
@bladyjoker bladyjoker mentioned this pull request Jan 26, 2023
Closed
@bladyjoker bladyjoker self-assigned this Jan 26, 2023
@bladyjoker bladyjoker requested a review from gnumonik January 26, 2023 19:50
@gnumonik gnumonik merged commit 3895701 into main Jan 27, 2023
@gnumonik gnumonik deleted the bladyjoker/compiler-typeclass-check branch January 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnumonik gnumonik gnumonik approved these changes

Assignees

@bladyjoker bladyjoker

@gnumonik gnumonik

Labels
compiler Work related to the Lambda Buffers Compiler enhancement New feature or request
Projects
Lambda Buffers
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bladyjoker @gnumonik