Kind Checker: CLI Integration #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstml
force-pushed
the
compiler/integrate-CLI-KindChecker
branch
from
edced52 to
67c5bcc
Compare
bladyjoker
suggested changes
Feb 1, 2023
There was a problem hiding this comment.
Hey Vlad,
There's still some work that needs to be done here, I see several issues:
- Too much of your internal concepts are exposed in the API, unificatino/substition is not something the Compiler API should talk about,
- Kind checking machinery is not tracking proper SourceInfo and you're inventing helper messages for the API,
- The errors you decided to expose are too granular and tied to your implementation rather than to what the API is about.
I reckon you try and explain to me what these errors mean I can help translate them into API concepts.
lambda-buffers-compiler/src/LambdaBuffers/Compiler/ProtoCompat/Types.hs
Outdated
Show resolved
Hide resolved
lambda-buffers-compiler/app/LambdaBuffers/Compiler/Cli/Compile.hs
Outdated
Show resolved
Hide resolved
bladyjoker
reviewed
Feb 1, 2023
bladyjoker
reviewed
Feb 1, 2023
bladyjoker
reviewed
Feb 1, 2023
bladyjoker
approved these changes
Feb 7, 2023
lambda-buffers-compiler/src/LambdaBuffers/Compiler/KindCheck/Context.hs
Outdated
Show resolved
Hide resolved
lambda-buffers-compiler/src/LambdaBuffers/Compiler/KindCheck/Variable.hs
Outdated
Show resolved
Hide resolved
lambda-buffers-compiler/src/LambdaBuffers/Compiler/KindCheck/Variable.hs
Outdated
Show resolved
Hide resolved
lambda-buffers-compiler/src/LambdaBuffers/Compiler/ProtoCompat/Types.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dražen Popović <bladyjoker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.