Skip to content

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Jan 11, 2024

The following types are added in this pr:

  • v1::assoc_map::AssocMap, also exported under v2.
  • v1::tuple::Tuple, also exported under v2
  • v1::transaction::{DCert, ScriptPurpose, TransactionInfo, ScriptContext}. DCert and ScriptPurpose are exported under v2::transaction as well.
  • v2::transaction::{TransactionInfo, ScriptContext}

IsPlutusData for types mentioned are implemented; plutus data round-trip tests are implemented

TODO:

  • doc
  • json round-trip tests

@chfanghr chfanghr self-assigned this Jan 11, 2024
@chfanghr chfanghr requested review from bladyjoker and szg251 January 11, 2024 16:57
Copy link
Collaborator

@szg251 szg251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work.
Other than the thing I mentioned yesterday (docs and JSON instances) I commented on one small thing.

@chfanghr chfanghr force-pushed the connor/script-context branch from a365fdd to dcd2cc3 Compare January 12, 2024 13:26
@chfanghr chfanghr requested a review from szg251 January 12, 2024 16:16
Copy link
Collaborator

@szg251 szg251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chfanghr chfanghr merged commit b57424c into master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants