-
Notifications
You must be signed in to change notification settings - Fork 1
add v1/v2 TransactionInfo
and related types
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`LinkedHashMap`
f1727f4
to
529778d
Compare
szg251
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work.
Other than the thing I mentioned yesterday (docs and JSON instances) I commented on one small thing.
szg251
reviewed
Jan 12, 2024
szg251
reviewed
Jan 12, 2024
a365fdd
to
dcd2cc3
Compare
szg251
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following types are added in this pr:
v1::assoc_map::AssocMap
, also exported underv2
.v1::tuple::Tuple
, also exported underv2
v1::transaction::{DCert, ScriptPurpose, TransactionInfo, ScriptContext}
.DCert
andScriptPurpose
are exported underv2::transaction
as well.v2::transaction::{TransactionInfo, ScriptContext}
IsPlutusData
for types mentioned are implemented; plutus data round-trip tests are implementedTODO: