Update all submodules, related fixes and mint automatization #16

ryukzak · 2022-06-22T13:55:27Z

Simplify NFT minting by the scripts. Details in updated README.md

Currently, scripts allow to mint new NFT for images, which can be founded in the marketplace sometime later. But it is impossible to buy due to: NFT not found on marketplace

Related PRs:

State:

Minting. Can't reproduce with vasil network. Two problems:
- Impossible to sync plutus-chain-index. Without it we can't mint the new NFT (https://mlabs-corp.slack.com/archives/C01UW1ESYP7/p1657354182077479).
- Looks like PBI version used is outdated for vasil, but can't check it due to the previous problem.
Buying. Updated CTL and seabug contract. Tested on testnet with vasil and should work.

…rror/reflection field for WS), seabug-contract and plutus-usecases

rynoV · 2022-06-28T15:21:42Z

I needed to add logLevel: 'Trace', here to get it to work, and should we also update this line in seabug-contracts/index.d.ts to include the logLevel?

How to check (with defaults): - http GET ctl.localho.st:8080/images - http GET ctl.localho.st:8080/fees

…tus-use-case

Update flake.lock

README.md

arion-compose.nix

samuelWilliams99 · 2022-07-08T13:25:20Z

arion-compose.nix

+                  "--server-api" "usr:pwd"
+                  "--ogmios-address" "ogmios" "--ogmios-port" "1337"
+                  "--origin" "--use-latest"
+                  "--block-filter" "{\"address\": \"addr_test1wr05mmuhd3nvyjan9u4a7c76gj756am40qg7vuz90vnkjzczfulda\"}"


This address seems like it shouldn't be hardcoded, is it the marketplace address?

Yes, it is. The issue on this: #18

This should be probably some const defined earlier in this file, it's constant after launch, it's marketplace escrow address

Co-authored-by: Samuel Williams <33094920+samuelWilliams99@users.noreply.github.com>

rynoV · 2022-07-27T18:57:47Z

Updated CTL submodule to the seabug-contracts version and checked:

CTL server is provided by the CTL submodule
- CTL submodule isn't used anywhere else afaict
seabug-contracts using pinned version
With updated CTL server:
- NFT listing working
- Purchasing working:
  - https://testnet.cardanoscan.io/transaction/c38b4e0d5dbabd950baa258159411c7cd5b61ac11f30372e0a8ea181d085a3db
  - https://testnet.cardanoscan.io/transaction/069f2ab15b22114e7c78df8e533c8590f5f2f844a994fe82cf25369cb62d6e08
- Minting then purchasing working:

…rketplace-server

…e-server Update `nft-marketplace-server`

rynoV · 2022-07-27T23:33:21Z

With dfaedae, from a clean repo:

I followed the steps in the readme to get everything setup
- I used my own nft.storage key in arion-compose.nix
I tested minting, and buying the minted NFT using localhost:8080 (the website served from the nft-marketplace service)
- This was in chromium version 103.0.5060.114 (Official Build) Arch Linux (64-bit), no extensions except nami and gero
- Only possible issue is that it seems the nginx routing isn't setup properly yet, so refreshing on any page except the root will give a 404
  - Possible solution is to use the development server instead, via cd nft-marketplace && nix develop -L ../seabug-contracts -c npm start
  - UPDATE: fixed now, routing is working with react-router
- Transactions from tests:

t4ccer · 2022-07-28T07:53:12Z

re using development server: Well, it's development server, we should rather fix nginx setup

t4ccer · 2022-07-28T07:53:56Z

arion-compose.nix

-  ogmios-datum-cache = (import ogmios-datum-cache/default.nix).packages.x86_64-linux.ogmios-datum-cache;
+  nft-marketplace-server = (import nft-marketplace-server/default.nix).packages.x86_64-linux."nft-marketplace-server:exe:nft-marketplace-server";
+  ogmios-datum-cache = (import ogmios-datum-cache/default.nix).packages.x86_64-linux."ogmios-datum-cache";
+  # FIXME: CTL version also pinned in seabug-contract. We need only one source of truth


Will be fixed when we'll move from git submodules to flakes, then you can just follow input

arion-compose.nix

t4ccer · 2022-07-28T07:55:37Z

arion-compose.nix

+                  "--server-api" "usr:pwd"
+                  "--ogmios-address" "ogmios" "--ogmios-port" "1337"
+                  "--origin" "--use-latest"
+                  "--block-filter" "{\"address\": \"addr_test1wr05mmuhd3nvyjan9u4a7c76gj756am40qg7vuz90vnkjzczfulda\"}"


This should be probably some const defined earlier in this file, it's constant after launch, it's marketplace escrow address

scripts/mint-nft.sh

t4ccer · 2022-07-28T08:02:10Z

README.md

@@ -69,73 +69,85 @@ Ensure that Nami is set to Testnet, that you have some Test Ada, and that you've

 ### Optional: Mint your own NFTs

-This process will be simplified in the future.
+UPDATE: see the minting section in `seabug-contracts/README.md` instead. The following minting process is currently broken, see [\#22](https://github.com/mlabs-haskell/seabug/issues/22).


Keeping broken process in readme can be confusing even if it's marked as broken

Unsure if its the right move to drop the full minting util, I feel like probably not, but we can certainly do so from the readme, and add back later once fixed

The new minting process partially relies on mint-nft.sh to upload an image to IPFS+our database and get its base36 CID, and some of the setup from this section of the readme is necessary for that to work. It's kind of hacky right now, but I'm not sure if it's worth trying to extract out the part of mint-nft.sh that we need.

Maybe we just remove mint-nft.sh for now, but keeping the parts that are needed? The file is in git anyways

See 43dad7d for what I meant. I can revert that commit if we want to keep the old version, but I feel like it'll just cause confusion

rynoV · 2022-07-28T14:46:05Z

re using development server: Well, it's development server, we should rather fix nginx setup

I can spend some time today fixing the nginx setup, I'm sure there's probably some tutorials for "nginx with <our react routing lib>" cc @samuelWilliams99 @t4ccer

nginx-default.conf is the /etc/nginx/conf.d/default.conf file copied from the nginx container, and I just added the `try_files` line

Synthetica9 · 2022-07-28T18:52:17Z

Currently merging this into #19, so that can be merged shortly after this is merged.

Aleksandr Penskoi added 3 commits June 21, 2022 19:58

Rewriting 'Mint you own NFT' in script, update readme.

701c6c5

Add base image for nft-market-place (fix ssl problem)

7cb4fe9

Update nft-marketplace to the dev version

18b272d

ryukzak changed the title ~~Draft: bump nftmarketplace version~~ Draft: bump nft-marketplace version Jun 22, 2022

nrutledge and others added 4 commits June 22, 2022 13:19

Fix frontend build scripts

04e02d1

Minor fixes

660e936

Update nft-marketplace-server, CTL, ODC version (correct work with mi…

3ed0664

…rror/reflection field for WS), seabug-contract and plutus-usecases

Temporal rollback ODC on non-master version.

60c6a99

rynoV mentioned this pull request Jun 28, 2022

Move Metadata code from CTL mlabs-haskell/seabug-contracts#7

Merged

ryukzak mentioned this pull request Jun 29, 2022

Datum fetch error with Shelley after Vasil support update mlabs-haskell/ogmios-datum-cache#100

Closed

Aleksandr Penskoi added 8 commits June 30, 2022 16:57

Fix mint-nft.sh. Bump plutus-use-cases and seabug-contract.

514a0bf

Fix CTL initialization

167f300

Rename ctl.localho.st to ctl.localho.st, add ctl.localho.st domain.

fa4937d

How to check (with defaults): - http GET ctl.localho.st:8080/images - http GET ctl.localho.st:8080/fees

Fix CORS problem by nginx configuration.

6ad09dd

Bump CTL to v2.0.0-alpha and update node config

8208690

Remove old testnet-config

992cfa4

Update cardano-node (flake and arion), gmios, seabug-contract and plu…

bb4da7a

…tus-use-case

Fix restart policy for arion-compose

6d8fce3

ryukzak changed the title ~~Draft: bump nft-marketplace version~~ Draft: Update CTL and other dependency, related fixes and mint automatization Jul 8, 2022

Aleksandr Penskoi added 2 commits July 8, 2022 13:03

Update flake.lock

d81ca27

Update flake.lock

Update testnet configuration (vasil hardfork)

b94bbf0

ryukzak force-pushed the aleksandr/bump-nftmarketplace branch from 45a6771 to b94bbf0 Compare July 8, 2022 10:03

samuelWilliams99 suggested changes Jul 8, 2022

View reviewed changes

ryukzak mentioned this pull request Jul 8, 2022

Draft: Aleksandr/mint script #15

Closed

ryukzak and others added 5 commits July 10, 2022 03:58

Update README.md

e69e4b9

Co-authored-by: Samuel Williams <33094920+samuelWilliams99@users.noreply.github.com>

Bump dependencies

617f0df

Add MINT-POLICY arg for mint-nft.sh. Update README.md

a33db0a

Update arion-compose.nix for new server version

1b305e1

Fix nft-marketplace-server setup

e1ec944

Fix but this time for real

16e90e3

rynoV mentioned this pull request Jul 27, 2022

Fix or remove minting scripts #22

Closed

rynoV added 3 commits July 27, 2022 10:01

Update plutus-use-cases to t4/testnet-script

b8a5e1c

Update readme to inform about outdated minting scripts

3ace383

Minor fixes to arion-compose.nix

b1a80ed

rynoV changed the title ~~Draft: Update CTL and other dependency, related fixes and mint automatization~~ Update all submodules, related fixes and mint automatization Jul 27, 2022

Update CTL to version used by seabug-contracts

b92239e

rynoV added 5 commits July 27, 2022 13:28

Merge branch 'aleksandr/bump-nftmarketplace' into calum/update-nft-ma…

f8db84b

…rketplace-server

Merge pull request #21 from mlabs-haskell/calum/update-nft-marketplac…

48923cd

…e-server Update `nft-marketplace-server`

Update seabug-contracts

3ec2e9d

Update nft-marketplace

961ef55

Update nft-marketplace-server to main

dfaedae

rynoV requested review from samuelWilliams99 and t4ccer July 27, 2022 23:39

t4ccer reviewed Jul 28, 2022

View reviewed changes

rynoV added 4 commits July 28, 2022 09:29

Fix nginx to work with react-router

3398d17

nginx-default.conf is the /etc/nginx/conf.d/default.conf file copied from the nginx container, and I just added the `try_files` line

Rename cardano node config json file

dde76dc

Extract marketplace escrow address to constant

1dfe8ea

Remove broken parts of mint-nft.sh and update readme

43dad7d

rynoV requested a review from t4ccer July 28, 2022 16:36

Reorganize nginx config files

fcae789

samuelWilliams99 approved these changes Jul 29, 2022

View reviewed changes

rynoV merged commit ac97bf3 into main Jul 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update all submodules, related fixes and mint automatization #16

Update all submodules, related fixes and mint automatization #16

ryukzak commented Jun 22, 2022 •

edited

Loading

rynoV commented Jun 28, 2022

samuelWilliams99 Jul 8, 2022

ryukzak Jul 10, 2022

t4ccer Jul 28, 2022

rynoV commented Jul 27, 2022 •

edited

Loading

rynoV commented Jul 27, 2022 •

edited

Loading

t4ccer commented Jul 28, 2022

t4ccer Jul 28, 2022

t4ccer Jul 28, 2022

t4ccer Jul 28, 2022

samuelWilliams99 Jul 28, 2022

rynoV Jul 28, 2022

rynoV Jul 28, 2022

rynoV commented Jul 28, 2022 •

edited

Loading

Synthetica9 commented Jul 28, 2022

Update all submodules, related fixes and mint automatization #16

Update all submodules, related fixes and mint automatization #16

Conversation

ryukzak commented Jun 22, 2022 • edited Loading

rynoV commented Jun 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rynoV commented Jul 27, 2022 • edited Loading

rynoV commented Jul 27, 2022 • edited Loading

t4ccer commented Jul 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rynoV commented Jul 28, 2022 • edited Loading

Synthetica9 commented Jul 28, 2022

ryukzak commented Jun 22, 2022 •

edited

Loading

rynoV commented Jul 27, 2022 •

edited

Loading

rynoV commented Jul 27, 2022 •

edited

Loading

rynoV commented Jul 28, 2022 •

edited

Loading