Add "ignore deny list" option when sending an email #360

mlandauer · 2020-08-13T00:29:53Z

No description provided.

It doesn't do anything or get populated properly

houndci-bot · 2020-08-13T00:30:01Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",
+          "",
+          "Hello!"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:01Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Content-Type: text/plain;",
+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",
+          "",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:01Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Mime-Version: 1.0",
+          "Content-Type: text/plain;",
+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:01Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Subject: Hello",
+          "Mime-Version: 1.0",
+          "Content-Type: text/plain;",
+          " charset=UTF-8",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:01Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Message-ID: <1.mail>",
+          "Subject: Hello",
+          "Mime-Version: 1.0",
+          "Content-Type: text/plain;",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:03Z

spec/lib/cuttlefish_smtp_server_spec.rb

+      end
+
+      it do
+        connection.receive_recipient("<wibble@wobble.com>")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:03Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",
+          "",
+          "Hello!"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:03Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Content-Type: text/plain;",
+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",
+          "",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:03Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Mime-Version: 1.0",
+          "Content-Type: text/plain;",
+          " charset=UTF-8",
+          "Content-Transfer-Encoding: 7bit",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:30:03Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Subject: Hello",
+          "Mime-Version: 1.0",
+          "Content-Type: text/plain;",
+          " charset=UTF-8",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:39Z

app/models/delivery.rb

@@ -29,7 +30,7 @@ def send?
    # If there is no team there is no deny list
    # In concrete terms the internal cuttlefish app doesn't have a deny
    # list and isn't part of a team
-    app.team.nil? || address.deny_lists.find_by(team_id: app.team.id).nil?
+    app.team.nil? || email.ignore_deny_list || address.deny_lists.find_by(team_id: app.team.id).nil?


Metrics/LineLength: Line is too long. [100/80]

houndci-bot · 2020-08-13T00:33:40Z

app/services/email_services/create.rb

@@ -50,6 +52,6 @@ def call

    private

-    attr_reader :app_id, :from, :to, :cc, :subject, :text_part, :html_part
+    attr_reader :app_id, :from, :to, :cc, :subject, :text_part, :html_part, :ignore_deny_list


Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2020-08-13T00:33:40Z

app/services/email_services/create.rb

@@ -3,7 +3,7 @@
 module EmailServices
  class Create < ApplicationService
    # rubocop:disable Naming/MethodParameterName
-    def initialize(app_id:, from:, to:, cc:, subject:, text_part:, html_part:)
+    def initialize(app_id:, from:, to:, cc:, subject:, text_part:, html_part:, ignore_deny_list:)


Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [8/5]
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
Metrics/LineLength: Line is too long. [97/80]

houndci-bot · 2020-08-13T00:33:40Z

lib/cuttlefish_smtp_server.rb

+    # Now check for special headers
+    m = Mail.new(current.data)
+    h = m.header[IGNORE_DENY_LIST_HEADER]
+    ignore_deny_list = (!h.nil? && h.value == "true")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:41Z

lib/cuttlefish_smtp_server.rb

@@ -165,17 +165,28 @@ def process_data_line(line)
    end
  end

+  IGNORE_DENY_LIST_HEADER = "X-Cuttlefish-Ignore-Deny-List"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:42Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "X-Cuttlefish-Ignore-Deny-List: true",
+          "Message-ID: <1.mail>",
+          "Subject: Hello",
+          "Mime-Version: 1.0",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:43Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "To: wibble@wobble.com",
+          "X-Cuttlefish-Ignore-Deny-List: true",
+          "Message-ID: <1.mail>",
+          "Subject: Hello",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:43Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "From: foo@bar.com",
+          "To: wibble@wobble.com",
+          "X-Cuttlefish-Ignore-Deny-List: true",
+          "Message-ID: <1.mail>",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:43Z

spec/lib/cuttlefish_smtp_server_spec.rb

+          "Date: Wed, 12 Aug 2020 06:25:22 +0000",
+          "From: foo@bar.com",
+          "To: wibble@wobble.com",
+          "X-Cuttlefish-Ignore-Deny-List: true",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2020-08-13T00:33:43Z

spec/lib/cuttlefish_smtp_server_spec.rb

+        [
+          "Date: Wed, 12 Aug 2020 06:25:22 +0000",
+          "From: foo@bar.com",
+          "To: wibble@wobble.com",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

coveralls · 2020-08-13T00:34:30Z

Coverage increased (+0.1%) to 74.78% when pulling 66a705f on ignore-deny-list into 86175d6 on master.

This reverts commit 67d3ad1, reversing changes made to 86175d6.

…st"" This reverts commit 489a589.

mlandauer added 11 commits August 12, 2020 15:26

Add option to email to ignore the deny list

aefb45f

It doesn't do anything or get populated properly

Add option to set ignore_deny_list in API

f12a886

Can now set special header in email to ignore_deny_list

2cd935c

Don't pass on special header

5e3843a

Extract value

086475a

Now respect ignore_deny_list setting

42d0d5d

Add crude documentation about the new special header

d2355f8

Explain that the deny list still gets populated

73e9bc2

boldify a word

c561eb6

seeds.rb needs to set ignore_deny_list field on Email

6713362

In the email detail view show when the email has "ignore deny list" set

e0d1d19

houndci-bot reviewed Aug 13, 2020

View reviewed changes

Stop test from trying to send an actual email

66a705f

houndci-bot reviewed Aug 13, 2020

View reviewed changes

mlandauer merged commit 67d3ad1 into master Aug 13, 2020

mlandauer deleted the ignore-deny-list branch August 13, 2020 00:39

mlandauer added a commit that referenced this pull request Aug 13, 2020

Revert "Merge pull request #360 from mlandauer/ignore-deny-list"

489a589

This reverts commit 67d3ad1, reversing changes made to 86175d6.

mlandauer added a commit that referenced this pull request Aug 13, 2020

Revert "Revert "Merge pull request #360 from mlandauer/ignore-deny-li…

c4f595c

…st"" This reverts commit 489a589.

mlandauer mentioned this pull request Aug 18, 2020

Improve deliverability and visibility on emails to planning authorities openaustralia/planningalerts#1466

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "ignore deny list" option when sending an email #360

Add "ignore deny list" option when sending an email #360

mlandauer commented Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

houndci-bot Aug 13, 2020

coveralls commented Aug 13, 2020 •

edited

Loading

Add "ignore deny list" option when sending an email #360

Add "ignore deny list" option when sending an email #360

Conversation

mlandauer commented Aug 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 13, 2020 • edited Loading

coveralls commented Aug 13, 2020 •

edited

Loading