[TextField] - Better TextField number support

[maxcan]

Description

Numeric TextFields don't render properly if you set their value to undefined for example, to show an empty field after a submit:

Before submit, looks good:

Afterwards when the value is correctly set to undefined:

Images/Screenshots

Link to a gist or code sample where the issue can be reproduced

Version

• React 15.4.2
• React-MD 1.1.x

[wdiechmann]

from http://materializecss.com/forms.html#input I remember that it is a "CSS-thing" - whether you could fix it that easy with react-md is beyond me (yet) :)

[mlaursen]

Yeah, the same thing can be accomplished by providing floating to your text field; it will make the label float. However, this might be something that should be handled by my component.

I have a couple of questions about the current flow:

• When you set the value to undefined, are you setting it by the value prop or something else?
• Have you tried setting the value to the empty string or 0 instead of undefined? (I think that might work out of the box)

[maxcan]

Value prop. Can try empty string

…

On Tue, Mar 7, 2017 at 06:06 Mikkel Laursen ***@***.***> wrote: Yeah, the same thing can be accomplished by providing floating to your text field; it will make the label float. However, this might be something that should be handled by my component. I have a couple of questions about the current flow: - When you set the value to undefined, are you setting it by the value prop or something else? - Have you tried setting the value to the empty string or 0 instead of undefined? (I think that might work out of the box) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAneTNchXmQw2MXKkqaWWSCua64lWEKlks5rjWOggaJpZM4MVHc-> .

[maxcan]

The empty string approach worked. Its a bit hacky since it's a numeric field, but definitely fine for now.

[mlaursen]

Ok, cool! I think I'll be implementing better text field number support in an upcoming release after the feedback I've gotten. The native input type="number" is pretty terrible, so it'll be good to update my component to fix some of those issues.