Support base variations inside combination of variations, fixes #38, support list in update_tags_from_env #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@anandhu-eng This is a core change and adding a useful feature. Please review. |
arjunsuresh
changed the title
anandhu-eng
reviewed
Jul 16, 2025
| for base_variation in variations[variation_name]["base"]: | ||
| tag_to_append = None | ||
| dynamic_base_variation = False | ||
| dynamic_base_variation_already_added = False |
There was a problem hiding this comment.
dead code? line 2613 is commented
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧾 PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.