Skip to content

Conversation

anandhu-eng
Copy link
Contributor

🧾 PR Checklist

  • Target branch is dev

πŸ“Œ Note: PRs must be raised against dev. Do not commit directly to main.

βœ… Testing & CI

  • No existing GitHub Actions are failing because of this change

πŸ“ File Hygiene & Output Handling

  • No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed

πŸ“ Comments & Communication

  • Proper inline comments are added to explain important or non-obvious changes
  • PR title and description clearly state what the PR does and why
  • Related issues (if any) are properly referenced (Fixes #, Related to #, etc.)
  • All reviewer feedback has been addressed

πŸ›‘οΈ Safety & Security

  • No secrets or credentials are committed
  • Paths, shell commands, and environment handling are safe and portable

@anandhu-eng
Copy link
Contributor Author

It seems that wmic is no longer installed by default from windows-2025(which is being fetched when used windows-latest).

@tanvi-mlcommons
Copy link

tanvi-mlcommons commented Sep 9, 2025

It seems that wmic is no longer installed by default from windows-2025(which is being fetched when used windows-latest).

yes that is correct. Can we ignore it? Can we do this some other way of auto-detecting without using wmic?

@anandhu-eng
Copy link
Contributor Author

I tried to use windows 2022 in this closed PR, but it did not solve the problem.

Can we ignore it? Can we do this some other way of auto-detecting using wmic?

Yes Tanvi, I think we could turn off the windows run for now and raise an issue to keep track of it. Once we find a fix, we could turn it back on.

@tanvi-mlcommons
Copy link

I tried to use windows 2022 in this closed PR, but it did not solve the problem.

Can we ignore it? Can we do this some other way of auto-detecting using wmic?

Yes Tanvi, I think we could turn off the windows run for now and raise an issue to keep track of it. Once we find a fix, we could turn it back on.

Or perhaps have some sort of a warning after evaluating absence of wmic - prompting users to install it manually - for the time being? Not sure if that's the kind of workflow we expect from users - just a thought!

@arjunsuresh
Copy link
Collaborator

I have removed wmic with a powershell command. It is used only in the detect-cpu script.

Copy link

@tanvi-mlcommons tanvi-mlcommons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandhu-eng anandhu-eng marked this pull request as ready for review September 10, 2025 18:02
@anandhu-eng anandhu-eng merged commit c5cc7fe into dev Sep 10, 2025
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants