-
Notifications
You must be signed in to change notification settings - Fork 20
Changes for supporting Llama2-70b - r5.0 #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that |
yes that is correct. Can we ignore it? Can we do this some other way of auto-detecting without using wmic? |
I tried to use windows 2022 in this closed PR, but it did not solve the problem.
Yes Tanvi, I think we could turn off the windows run for now and raise an issue to keep track of it. Once we find a fix, we could turn it back on. |
Or perhaps have some sort of a warning after evaluating absence of wmic - prompting users to install it manually - for the time being? Not sure if that's the kind of workflow we expect from users - just a thought! |
I have removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
π§Ύ PR Checklist
dev
π Note: PRs must be raised against
dev
. Do not commit directly tomain
.β Testing & CI
π File Hygiene & Output Handling
π Comments & Communication
Fixes #
,Related to #
, etc.)π‘οΈ Safety & Security