Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add const keyword to methods wherever appropriate #63

Open
aniketsharma00411 opened this issue Jan 2, 2021 · 5 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers medium
Projects

Comments

@aniketsharma00411
Copy link
Member

aniketsharma00411 commented Jan 2, 2021

Note: You can contact @ashok-arora if you face any problem while solving this issue.

It is impossible to work with const Matrix objects as none of the methods are declared const.

Description

Using a const Matrix object I can't even call basic methods like row_length(), col_length(), print(), etc. as none of these are declared const` even though they are not changing the object value.

Expected Behavior

row_length(), col_length() and other methods not changing the object should run when called using a const Matrix object.

Actual Behavior

row_length(), col_length() and other methods not changing the object give error when when called using a const Matrix object.

Possible Fix

Add const keyword to methods which will not change the object value.

@aniketsharma00411 aniketsharma00411 created this issue from a note in Timeline (Todo) Jan 2, 2021
@aniketsharma00411 aniketsharma00411 added bug Something isn't working good first issue Good for newcomers medium labels Jan 2, 2021
@nishihere19
Copy link
Contributor

Can I work on this?

@ashok-arora
Copy link
Member

Can I work on this?

Sure!
Let me know if you face any difficulty!

@aniketsharma00411
Copy link
Member Author

@nishihere19 Please let us know if you are working on the issue or not.

@nishihere19
Copy link
Contributor

Sorry, I have some work at hand these days. I won't be able to work on this.

@aniketsharma00411
Copy link
Member Author

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers medium
Projects
Timeline
  
Todo
Development

No branches or pull requests

3 participants