Initial framework #1

ghost · 2019-05-03T22:03:59Z

No description provided.

todo · 2019-05-04T11:53:05Z

Access Keys Rotated rule needs testing

https://github.com/servian/aws-auto-remediate/blob/c1239a6bbf0e1c386970d2dcd4106cb77f6456b6/auto-remediate/config_rules.py#L13-L18

This comment was generated by todo based on a `TODO` comment in `c1239a6` in #1. cc @servian.

todo · 2019-05-06T10:03:58Z

Check how many times this message was retried, if 3 times then stop sending to DLQ

https://github.com/servian/aws-auto-remediate/blob/bbbf98eafba37947511c5d7e59fcd8949ffbcb95/auto-remediate/lambda_handler.py#L89-L94

This comment was generated by todo based on a `TODO` comment in `bbbf98e` in #1. cc @servian.

Marat Levit added 12 commits May 2, 2019 22:12

Initial dirty commit... DO NOT USE

0e3bcfd

Added checks for existing stacks

dd92a06

Added CloudWatch Event and SNS topic

95b4e1b

Added rule name and compliance retrieval

522b841

Better function orginisation

56f5dc4

Added better logging and structure for calling remediation jobs

a8ccccf

Added settings table and removed unused imports

029db72

Fixed issues when parsing SNS record

cb40e19

Fixed README

a0bda48

Added partial support for rds-instance-public-access-check

e3d5f86

Removed extra white spacing in README

abc3766

Renamed function to auto-remediate-setup

2208b60

This comment has been minimized.

Sign in to view

Marat Levit added 3 commits May 4, 2019 08:21

Updated README formatting

782cb91

Added DLQ function

800347b

Tweaked function timeouts

b7ef72b

This comment has been minimized.

Sign in to view

Marat Levit added 7 commits May 4, 2019 09:09

Added more information regarding the 3 functions

f0cc77c

Added DLQ function functionality (not tested)

a31b953

Removed old CHANGELOG

cd026e1

Code quality fixes based on Codacy feedback

2b8149e

Added Codacy badge

00a7831

Code quality fixes based on Codacy feedback

c669400

Added SNS logging (not tested)

8d11480

This comment has been minimized.

Sign in to view

Marat Levit added 2 commits May 4, 2019 19:33

Added incomplete remediation code for access-keys-rotated rule

fc3e045

Renamed environment variables

8c363c2

This comment has been minimized.

Sign in to view

Fixed syntax error

c9f125e

ghost modified the milestone: Public release May 4, 2019

Marat Levit added 10 commits May 5, 2019 10:01

Added app diagram

6d695d3

Updated README

20ee937

Failed remediation is now sent to DLQ

bb1e22c

Changed SNS log format and changed execution error format

6007e97

Updated README diagram

728435a

Removed SNS testing TODO

76e2dbf

Fixed console logging

2648639

Changed DLQ function to send message to SQS instead of invoking Lambda

bf646af

Updated AWS diagram

4ac611e

Fixed DLQ messages

bbbf98e

Marat Levit added 5 commits May 6, 2019 20:06

Added comment to stage variable

d09d346

Commented out access-keys-rotated code

f0bd6dd

Added badges to README

ab76949

Added spaces between badges

e7c29ba

Removed unused imports

eeef1b4

This was referenced May 6, 2019

If Stack deployment has been set to False delete the Stack from CloudFormation #5

Closed

Prevent CloudFormation Stacks from being deployed if they're set to False in the Settings #6

Closed

ghost marked this pull request as ready for review May 6, 2019 10:39

ghost merged commit 6a60ff5 into master May 6, 2019

ghost deleted the initial branch May 7, 2019 02:44

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial framework #1

Initial framework #1

ghost commented May 3, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

todo bot commented May 4, 2019

This comment has been minimized.

todo bot commented May 6, 2019

Initial framework #1

Initial framework #1

Conversation

ghost commented May 3, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

todo bot commented May 4, 2019

Access Keys Rotated rule needs testing

This comment was generated by todo based on a TODO comment in c1239a6 in #1. cc @servian.

This comment has been minimized.

todo bot commented May 6, 2019

Check how many times this message was retried, if 3 times then stop sending to DLQ

This comment was generated by todo based on a TODO comment in bbbf98e in #1. cc @servian.

This comment was generated by todo based on a `TODO` comment in `c1239a6` in #1. cc @servian.

This comment was generated by todo based on a `TODO` comment in `bbbf98e` in #1. cc @servian.