This repository has been archived by the owner. It is now read-only.
Parser test 1 #18
Merged
Parser test 1 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l we can get the real thing
Specialist search on catalog with new query parser
…essages Add structured data to the error messages.
The entire issue with specialist search has been that different datastores have different search fields. Sidestep all of that by simply re-parsing the original search using the specialist search config, which is always catalog search, which on this branch is always using new parser.
Re-parse the original search for specialist search purposes
Now that we are merging the actual query into our solr params for the specialist search, don't need to copy q, fq, and df from the query. We do need rows and fields which are specific to specialist search
Remove extraneous stuff from specialist query params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in the new parser.