feat: Implement Lightcycler XML parsing with validation for unique sa… #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2025 12:43
There was a problem hiding this comment.
Pull Request Overview
This PR implements XML parsing functionality for Lightcycler sample sheets with validation for unique sample coordinates. The implementation includes comprehensive error handling for missing properties, invalid data types, and duplicate coordinates.
- Added
LightcyclerXmlParserclass to parse XML files containing sample data - Created validation logic for required properties, data consistency, and coordinate uniqueness
- Implemented comprehensive error handling with custom exception classes
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/LightcyclerExportSheet/QpcrXmlParserTest.php |
Comprehensive test suite covering XML parsing, validation, error handling, and edge cases |
src/LightcyclerExportSheet/LightcyclerXmlParser.php |
Main XML parser class with sample extraction and validation logic |
src/LightcyclerExportSheet/LightcyclerSample.php |
Data class representing a Lightcycler sample with coordinates and measurements |
src/LightcyclerExportSheet/LightcyclerDataParsingTrait.php |
Shared parsing utilities for data validation, cleaning, and coordinate uniqueness checks |
src/LightcyclerExportSheet/MissingRequiredPropertyException.php |
Custom exception for missing required XML properties |
src/LightcyclerExportSheet/DuplicateCoordinatesException.php |
Custom exception for duplicate sample coordinates |
composer.json |
Added ext-simplexml dependency for XML parsing |
CHANGELOG.md |
Updated changelog entry for the new feature |
spawnia
reviewed
Aug 11, 2025
src/LightcyclerExportSheet/MissingRequiredPropertyException.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedikt Franke <benedikt.franke@mll.com>
spawnia
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mple coordinates
Changes
Support parsing Lightcycler Sample Sheets from XML-file #56