Change mnist full to mnist train #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that mnist full was just a sample of the original mnist dataset with around 700 lines. The mnist train has at least 66K lines. It should be enough for this example. Signed-off-by: Omar Shrit <omar@shrit.me>
|
Ahh, Awesome. Thanks a lot for this. |
Closed
birm
changed the title
birm
approved these changes
May 31, 2020
|
Hey @birm, Can we wait before we merge this. |
|
Currently this model doesn't work. I made the changes the makes the model compile in a PR in mlpack/mlpack#2436. However the model doesn't work with mnist_train.csv. So either changes in model must be made or we can download mnist_full.csv. I am trying to work on solution. |
birm
requested changes
May 31, 2020
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
|
Keep open |
|
I think this pull request is no longer needed since @hello-fri-end has already integrated these changes in his pull request. I am closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that mnist full was just a sample of the original
mnist dataset with around 700 lines. The mnist train has at least
66K lines. It should be enough for this example.
Signed-off-by: Omar Shrit omar@shrit.me