Skip to content

CPO documentation #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: gh-pages
Choose a base branch
from
Open

CPO documentation #118

wants to merge 23 commits into from

Conversation

mb706
Copy link

@mb706 mb706 commented Aug 24, 2017

  • work in progress -

@mb706
Copy link
Author

mb706 commented Jan 7, 2018

Current status of the tutorial can be seen here.

I have now made the tutorial imho long enough to be informative and short enough to be interesting for someone learnign mlr in combination with CPO. I am not mentioning retrafo() and inverter() much, since attaching a CPO to a Learner does all the retrafo-related things internally, so I don't think it should be in an introductory tutorial.

I also mention the vignette which goes more in-depth.

When more things in mlr get replaced by mlrCPO equivalents the respective tutorial pages could also be updated.

@mb706
Copy link
Author

mb706 commented Jan 7, 2018

(Travis build script currently pulls the paramSetSugar branch of ParamHelpers)

@larskotthoff
Copy link
Contributor

So is this ready to be merged now?

mb706 added 3 commits January 11, 2018 23:15
This documentation is not yet online; for that, mlrCPO would need to be on CRAN or get about 37 stars on github.
@mb706
Copy link
Author

mb706 commented Jan 11, 2018

I'm not sure if this should be merged before mlrCPO is on CRAN (otherwise I could adjust the introduction that mlrCPO should be installed from github for now; using the paramSetSugar branch of ParamHelpers in the travis script also a crutch that would need fixing first), but I think the document is otherwise "done". I welcome feedback on whether I should go more or less in detail at points.

@larskotthoff
Copy link
Contributor

Ok, please ping when everything is ready!

@pat-s
Copy link
Collaborator

pat-s commented Jun 22, 2018

@mb706 Can you port this PR to the pkgdown files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants