Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds test for print.ParamSet. Closes #1352 #1419

Merged
merged 4 commits into from
Jan 11, 2017
Merged

adds test for print.ParamSet. Closes #1352 #1419

merged 4 commits into from
Jan 11, 2017

Conversation

florianfendt
Copy link
Contributor

Added a test for the ParamSet printer in testThatLearnerCanTrainPredict and generalized the function name to testBasicLearnerProperties.
Other name suggestions for the function?
We do the following in this function:

  • check printer for learner and ParamSet
  • check train/predict
  • check predict types se and prob

@larskotthoff
Copy link
Member

Thanks. Could you update the documentation for that function as well please?

@berndbischl
Copy link
Member

otherwise looks good

@larskotthoff
Copy link
Member

Thanks, merging.

@larskotthoff larskotthoff merged commit 9534394 into master Jan 11, 2017
@larskotthoff larskotthoff deleted the test_paramset_printer branch January 11, 2017 17:30
smilesun pushed a commit that referenced this pull request Feb 9, 2017
@florianfendt @smilesun
adds test for print.ParamSet. Closes #1352 (#1419)
923b998 
* test for print.ParamSet closes #1352

* rm unwanted bin file

* adjust other tests in learners_all

* update function docu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianfendt @larskotthoff @berndbischl