Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilabel wrapper all #977

Merged
merged 19 commits into from
Jul 11, 2016
Merged

Multilabel wrapper all #977

merged 19 commits into from
Jul 11, 2016

Conversation

giuseppec
Copy link
Contributor

@giuseppec giuseppec commented Jul 1, 2016

  • we need to add a reference + short description in the note field for the measures
  • we need manual tests for the measures like here: https://github.com/mlr-org/mlr/blob/master/tests/testthat/test_base_measures.R#L271 where we create a small matrix and compare the measure function with its expected output
  • write 1-2 pages for the tutorial
  • use checkLearner(, props = ...) instead of hasLearnerProperties(...)
  • check styleguide (also check if the data type is mentioned in the API)
  • set the order arg to NULL and explain that by default this does "random" sampling. Also, use a vector with label names instead of indices for the order arg.
  • Make multilabel-randomForestSRC ready (see Multilabel randomForestSRC #991)
  • implement Parallelization (Zachs PR parallel ensembles #615)
  • Review paper and send it to the RJournal

@berndbischl
Copy link
Member

please note that this PR #959 already contains generic code to test all basic multilabel RLearners
(learners_all style)

@giuseppec
Copy link
Contributor Author

@PhilippPro could you help here and look at points 1-3 from the list above? I'll do 4-6.

@PhilippPro
Copy link
Member

Yes. next week.

giuseppec and others added 4 commits July 4, 2016 10:39
Added notes and reference for the measures. The reference can be replaced by our paper, when it is published.
@berndbischl berndbischl mentioned this pull request Jul 11, 2016
@berndbischl berndbischl merged commit 7f5e598 into master Jul 11, 2016
@mllg mllg deleted the multilabel_wrapper_all branch August 11, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants