-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNX support #14
DNX support #14
Conversation
Should the project.lock.json be checked in? |
Also, I am a bit new to working with the new DNX projects. Can you shared the simple steps for building the solution command line and running tests? |
building from the command line for dnx is a little bit tricky as a user can install different versions of the tooling, build against different versions, etc. in addition to running different runtimes e.g. CLR, Core CLR. We use F# FAKE in our project to smooth over a lot of this to
Maybe it'd be worth putting something similar in for this? If not, the dnx tooling command line wiki has some details on the commands available. Oh, with project.lock.json, it's debatable about whether it should be checked in or not; looks like the team is advocating to not check it in 😄 |
Ok, so please remove the lock files :) I tried to use "dotnet build" but it needs a project.json, how can I use that to build all project.json files? |
Unfortunately I don't believe it is possible to build all projects with one command; each project (and project.json) needs to be built separately |
So with this code would I build each solution separately and generate two different nuget packages? |
With this solution, when you execute dnu pack in the directory of the project that you wish to build nuget packages for, it will build each framework version specified in the project.json and package them all into one nuget package. Would you prefer a PR using the newer dotnet CLI? |
Yes please. Lets use the newer dotnet CLI. |
Closing in favour of #17. Updated to .NET Core 1.0 (can update this to .NET Core 1.1 if need be). |
Added Core CLR support targeting net45 and dotnet TFMs i.e. .NET 4.5 onwards and Core CLR.
Converted
Addresses #12
An alternative way to support CoreCLR would be to convert the existing PCL library to target .NET Core using Oren Novotny's ReferenceGenerator, although this PR is probably more progressive in the direction the tooling is headed 😄
May need to make .csproj and project.json play nicely together (search for This is actually slightly problematic).
We have been using a MyGet hosted version of this for NEST/Elasticsearch.Net since January without issues.