Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how do i download / use #130

Open
skeddles opened this issue May 2, 2024 · 16 comments
Open

how do i download / use #130

skeddles opened this issue May 2, 2024 · 16 comments
Labels

Comments

@skeddles
Copy link

skeddles commented May 2, 2024

im trying to download it for windows, but everything i downloaded just seems to be a copy of the repo and no executables

@mmitch
Copy link
Owner

mmitch commented May 2, 2024

That's correct, there are no executables for Windows.
You will have to compile it yourself, see also here: #102 (comment)

@mmitch mmitch added the windows label May 2, 2024
@ruby-R53
Copy link

ruby-R53 commented May 3, 2024

why is it like that though? have you considered using a windows VM/spare computer to make binary releases for it?

@mmitch
Copy link
Owner

mmitch commented May 14, 2024

For me personally it's because I don't use Windows, so tha feature has a lower priority than other gbsplay stuff/other computing stuff/the rest of my life and so it just never happens.

@mrehkopf had some initial success with cross-compiling to a native windows binary, but there were some issues with the terminal output I think. I did not yet have any time to look into it.

@mmitch
Copy link
Owner

mmitch commented May 14, 2024

If we get the cross-compiling running with a usable result, we should be able to put it into a GitHub Action pipeline and create .exe files as downloadable artifacts on the release pages.

@mrehkopf
Copy link
Collaborator

Since we already have native Windows builds in the pipeline, shouldn't it suffice to use their artifacts to roll a release? I just have no idea how this actions/pipeline stuff works. ^^;

@mmitch
Copy link
Owner

mmitch commented May 14, 2024

I think we would need a "standalone" .exe.

For example the binary from the Cygwin build would only run under Cygwin (I think).
Can I take an .exe built for MinGW and run it on any other Windows or do I need some mingw.dll alongside to make it work?
I don't know anything about that stuff at all :)

@mmitch
Copy link
Owner

mmitch commented May 14, 2024

I can take on the pipeline part, barring time and motivation…

@ruby-R53
Copy link

ah, that makes sense

@mrehkopf
Copy link
Collaborator

Here is a statically linked build artifact from a modified windows pipeline:
https://github.com/mmitch/gbsplay/actions/runs/9120268396/artifacts/1511366094
Could you try running in on Windows and see if it works?

@mmitch
Copy link
Owner

mmitch commented May 17, 2024

I think that artifact is only visible for project members because it's on a subpage of the GitHub Actions - the pipeline runs aren't public because something something logfiles.

I plan to include the standalone.exe build pipline into our release pipeline over this weekend.
Then we can do a beta release. The artifacts on the release page should be public.

@mmitch
Copy link
Owner

mmitch commented May 17, 2024

Or I'll just try an attachment in this comment :-)
standalone Windows binary.zip

@mmitch
Copy link
Owner

mmitch commented May 17, 2024

note to self: add a version number/tag/commit id to the artifact name or we'll have a lot of indistinguishable standalone Windows binary.zip files on our hands…

@mmitch
Copy link
Owner

mmitch commented May 24, 2024

@skeddles Comment #130 (comment) contains a binary
Could you please test if it works for you?

@skeddles
Copy link
Author

skeddles commented Jun 3, 2024

the help printout runs, though i cant really figure out how to use it

@mrehkopf
Copy link
Collaborator

mrehkopf commented Jun 3, 2024

It's a command line player first and foremost, it takes the GBS file as an argument. To use it you could either:

  • open a command window (cmd or powershell) in the folder where you put gbsplay.exe, then type gbsplay followed by a space and the name of your GBS file, e.g. gbsplay d:\music\gbs\mario.gbs
  • drag&drop one of your GBS files on the player executable (gbsplay).

(I'd recommend the first option because it allows you to make some settings, e.g. disable the 2 minute playback limit)

If the player starts and displays the usage text without any weird DLL error windows or warnings from Windows about missing libraries, that's a good sign already though :)

@skeddles
Copy link
Author

skeddles commented Jun 3, 2024

okay yup, it seems to be working, shows the song output and plays the music

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants