Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

either use code coverage or don't :) #31

Closed
mmitch opened this issue Jun 30, 2020 · 1 comment
Closed

either use code coverage or don't :) #31

mmitch opened this issue Jun 30, 2020 · 1 comment
Assignees
Labels

Comments

@mmitch
Copy link
Owner

mmitch commented Jun 30, 2020

The travis.yml file currently contains part of a code coverage tool at the end:

after_success:
  - bash <(curl -s https://codecov.io/bash)

This code snippet would upload the coverage results to codecov.io, but we don't create any coverage data during our test run.
The build log looks like this in the final step:

$ bash <(curl -s https://codecov.io/bash)

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-20200629-ffaf297


==> Travis CI detected.
    project root: .
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
--> No coverage report found.
    Please visit http://docs.codecov.io/docs/supported-languages

Done. Your build exited with 0.

We should either generate coverage data and see what else is missing for codecov.io upload
or remove the after_success block altogether.

(also: piping curl to bash - yuck ;-)

@mmitch mmitch added the coding label Jun 30, 2020
@mmitch mmitch changed the title either use code coverage or not :) either use code coverage or don't :) Jun 30, 2020
@mmitch mmitch self-assigned this Jul 1, 2020
mmitch added a commit that referenced this issue Jul 1, 2020
@mmitch
Copy link
Owner Author

mmitch commented Jul 1, 2020

Coverage of the the gcc build w/o shared library test run is available at https://codecov.io/gh/mmitch/gbsplay

@mmitch mmitch closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant