add binary_result to send_query and send_query_prepared #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick merge! |
|
Thanks for the contribution! |
|
Coming a bit late, but I just found this PR while I was started to work on the same stuff... I believe there is a bug in this PR : |
|
Alain Frisch ***@***.***> writes:
*
alainfrisch left a comment (mmottl/postgresql-ocaml#52)
Coming a bit late, but I just found this PR while I was started to work on the same stuff...
I believe there is a bug in this PR : PQsendQueryParams_stub should use PQsendQueryParams when binary_result, even if nparams == 0
(like in PQexecParams_stub).
Hello,
Yes this is probably true. How to fix that now that the PR is merged ? I
guess a separate PR ?
Cheers,
Christophe
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
--
Christophe Raffalli
web: https://raffalli.eu
|
|
Yes, creating a new PR will be easiest. @craff could you please prepare one, I'll merge it then. |
|
Markus Mottl ***@***.***> writes:
The PR is done.
Cheers,
Christophe
… *
mmottl left a comment (mmottl/postgresql-ocaml#52)
Yes, creating a new PR will be easiest. @craff could you please prepare one, I'll merge it then.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
--
Christophe Raffalli
web: https://raffalli.eu
|
|
Markus Mottl ***@***.***> writes:
Strange error dune mmissing when the PR is tested on github ?
… *
mmottl left a comment (mmottl/postgresql-ocaml#52)
Yes, creating a new PR will be easiest. @craff could you please prepare one, I'll merge it then.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
--
Christophe Raffalli
web: https://raffalli.eu
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all ?