Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenEXR library dependency. #37

Closed
syoyo opened this issue Sep 17, 2014 · 3 comments
Closed

Remove OpenEXR library dependency. #37

syoyo opened this issue Sep 17, 2014 · 3 comments

Comments

@syoyo
Copy link

syoyo commented Sep 17, 2014

Please consider to use tinyexr, embeddable OpenEXR image loader into PBRTv2(or maybe v3?).

https://github.com/syoyo/tinyexr

I saw many PBRT beginner struggle to build and link ILM's OpenEXR library into PBRT, before they actually start to use/hack PBRT.

tinyexr will solve such a problem and users can concentrate on doing light transport using PBRT. It seems tinyexr already has enough features to replace ILM's OpenEXR lib(writing EXR image is not yet, but you can use miniexr https://github.com/aras-p/miniexr )

@mmp
Copy link
Owner

mmp commented Sep 17, 2014

I was already planning on trying it for v3 (with Aras's EXR writer). :-)

I definitely agree that having to build OpenEXR is a big bother for people who just want to get started using pbrt, so my basic plan is to adopt those and try to make that work.

It's probably worth trying this soon for v2, to make it easier before v3 comes out.

@syoyo
Copy link
Author

syoyo commented Sep 17, 2014

Cool!

Let me know if you find any missing features in tinyexr. I'll try to implement it.

@mmp
Copy link
Owner

mmp commented Aug 9, 2017

Fixed in v3 by including openexr in the cmake build; will not fix for v2 at this point.

@mmp mmp closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants