Consider to add a tag like '2.0' to pbrt?

[drakeguan]

Wondering if you can consider to put a tag like '2.0' to the repo to make a record of what 2.0 is. Then you can keep work on 'master' branch for other development. Furthermore, that also helps to put pbrt into mxcl/homebrew.

For package manager like homebrew, it is best to grab the source from a publish and static way then a dynamic 'master' branch. I like to help provide the necessary homebrew formula for pbrt as soon as you can provide a tag :)

[mmp]

I'd love to see pbrt in homebrew; I use homebrew myself and think it's great.

There really isn't any ongoing development in the pbrt-v2 tree; the head of that represents pbrt 2.0 as it appeared in the book, with only bugfixes and no additional development. So I'm not sure what a 2.0 tag would be good for; in general anyone using it should be running from the head of master, which is quite stable.

So I'm not sure what the right thing to do is?

Thanks,
-matt

On Sep 25, 2012, at 9:20 PM, Shuen Huei Guan notifications@github.com wrote:

Wondering if you can consider to put a tag like '2.0' to the repo to make a record of what 2.0 is. Then you can keep work on 'master' branch for other development. Furthermore, that also helps to put pbrt into mxcl/homebrew.

For package manager like homebrew, it is best to grab the source from a publish and static way then a dynamic 'master' branch. I like to help provide the necessary homebrew formula for pbrt as soon as you can provide a tag :)

—
Reply to this email directly or view it on GitHub.

[drakeguan]

Please take a look at this pull request of adding a formula into homebrew:

Homebrew/legacy-homebrew#7583

Drake

On Thu, Oct 4, 2012 at 1:39 AM, Matt Pharr notifications@github.com wrote:

I'd love to see pbrt in homebrew; I use homebrew myself and think it's
great.

There really isn't any ongoing development in the pbrt-v2 tree; the head
of that represents pbrt 2.0 as it appeared in the book, with only bugfixes
and no additional development. So I'm not sure what a 2.0 tag would be good
for; in general anyone using it should be running from the head of master,
which is quite stable.

So I'm not sure what the right thing to do is?

Thanks,
-matt

On Sep 25, 2012, at 9:20 PM, Shuen Huei Guan notifications@github.com
wrote:

Wondering if you can consider to put a tag like '2.0' to the repo to
make a record of what 2.0 is. Then you can keep work on 'master' branch for
other development. Furthermore, that also helps to put pbrt into
mxcl/homebrew.

For package manager like homebrew, it is best to grab the source from a
publish and static way then a dynamic 'master' branch. I like to help
provide the necessary homebrew formula for pbrt as soon as you can provide
a tag :)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-9115099.

Web: http://drakeguan.org/

[drakeguan]

In homebrew, a formula referring to the HEAD version of a source tree is not accepted because HEAD is dynamic while a tag is static.

[mmp]

Ok, got it.

I added a "2.0.334" tag for the current HEAD (since there have been 334 commits since the initial pbrt-v2 release). I'll try to remember to update with new tags in the future...

Thanks!

-matt

On Oct 7, 2012, at 8:25 PM, Shuen Huei Guan notifications@github.com wrote:

In homebrew, a formula referring to the HEAD version of a source tree is not accepted because HEAD is dynamic while a tag is static.

—
Reply to this email directly or view it on GitHub.

[drakeguan]

Just like to inform you that the pull request of pbrt 2.0 to homebrew has been in waiting list. I will keep eyes on this until it is accepted finally. The current formula doesn't check for libtiff. I like to make pbrt accepted in homebrew asap, and then add some further options later on.

[mmp]

Great--thanks!

On Oct 14, 2012, at 6:45 PM, Shuen Huei Guan notifications@github.com wrote:

Just like to inform you that the pull request of pbrt 2.0 to homebrew has been in waiting list. I will keep eyes on this until it is accepted finally.

—
Reply to this email directly or view it on GitHub.

[drakeguan]

Just like to let you know that pbrt got accepted into homebrew! Thanks for your help on this.

[mmp]

Fantastic!

On Oct 25, 2012, at 8:43 AM, Shuen Huei Guan notifications@github.com wrote:

Just like to let you know that pbrt got accepted into homebrew! Thanks for your help on this.

—
Reply to this email directly or view it on GitHub.