Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some stale comments #1036

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

k-sareen
Copy link
Collaborator

@k-sareen k-sareen commented Dec 4, 2023

No description provided.

@k-sareen k-sareen requested a review from wks December 4, 2023 05:01
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but object_reference_write_slow is a method of trait Barrier, but Barrier is private, and there is no wrapper for it in memory_manager.rs. I wonder why the OpenJDK binding is able to call it via

        mutator
            .barrier()
            .object_reference_write_slow(src, slot.into(), target);

@k-sareen
Copy link
Collaborator Author

k-sareen commented Dec 4, 2023

Weird. I'm not sure. There's no pub use barriers::Barrier anywhere.

@k-sareen k-sareen added this pull request to the merge queue Dec 4, 2023
Merged via the queue into master with commit a058b8c Dec 4, 2023
19 checks passed
@k-sareen k-sareen deleted the k-sareen-update-stale-comments branch December 4, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants