HHE propose some fixes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2021 17:54
... otherwise an asyncio.subprocess pipe is never terminated Fixes jhenstridge#5
... conflicting type names made the optional not so optional (always overriding).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes optional signint override;
RawMainLoop = MainLoop.__bases__[0]returns the type of MainLoop, seems to be due to a name conflict with it's super (also called GLib.MainLoop, be it in other file scope). This results inhandle_sigintnot really doing much, is stuck in True option regardless of its value.Fixes blocking subprocess pipe;
Map
condition & GLib.IOCondition.HUPto selector.EVENT_READ is required to fix this