Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for onset and duration in event.json file #1254

Closed
JuliusWelzel opened this issue May 26, 2024 · 1 comment · Fixed by #1255
Closed

Add descriptions for onset and duration in event.json file #1254

JuliusWelzel opened this issue May 26, 2024 · 1 comment · Fixed by #1255

Comments

@JuliusWelzel
Copy link
Contributor

JuliusWelzel commented May 26, 2024

Describe the problem

As currently implemented, the events.json file being written does not contain information about the two required columns "onset" and "duration" in the .json file.

As those columns are REQURIED, I would propose adding some background information to the .json file every time events are written for people who are not familiar with the structure of the events.tsv files in.REQUIRED

Describe your solution

Addiing this to the events_json function

  "onset": {
        "Requirement Level": "REQUIRED",
        "Data type": "number",
        "Description": (
            "Onset (in seconds) of the event from the beginning of the first data point. "
            "Negative onsets account for events before the first stored data point. "
            "This column must appear first in the file."
        )
    },
    "duration": {
        "Data type": "number or 'n/a'",
        "Description": (
            "Duration of the event in seconds from onset. Must be zero, positive, or 'n/a' if unavailable. "
            "A zero value indicates an impulse event.\n"
            "This column must appear second in the file."
        )
    }

Adding

Describe possible alternatives

As the documentation about this is specific on the BIDS website, it does not has to be implemented.

Additional context

No response

@agramfort
Copy link
Member

agramfort commented May 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants