MRG: Make Inspector work even if mne-qt-browser is installed #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now explicitly request a Matploblib plotting context for bringing up the Inspector. Otherwise, our MNE will default to using the qt-browser, and our current implementation of the Inspector will fail to launch.
hoechenberger
force-pushed
the
fix-inspect
branch
from
c6d451c
to
9c1ada9
Compare
hoechenberger
changed the title
|
Failing doc build is due to a bug in MNE-NIRS and unrelated to my changes: |
|
This is good to merge from my end. |
sappelhoff
approved these changes
May 15, 2022
|
Thanks @hoechenberger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now explicitly request a Matploblib plotting context for bringing up the Inspector. Otherwise, MNE will default to
using the qt-browser if installed, and our current implementation of the Inspector will fail to launch.
This didn't show up in unit tests before as we're using the Agg backend there.
Merge checklist
Maintainer, please confirm the following before merging: