Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] MAINT: Use new GitHub issue forms (yml) #1056

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 26, 2022

PR Description

closes #1043

to get a preview of how it looks and feels, try opening an issue (bug or feature) here: https://github.com/bids-standard/bids-specification/issues/new/choose

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff sappelhoff changed the title MAINT: Use new GitHub issue forms (yml) [MRG] MAINT: Use new GitHub issue forms (yml) Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1056 (2ed9b9f) into main (3f77995) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ed9b9f differs from pull request most recent head 876d61a. Consider uploading reports for the commit 876d61a to get more accurate results

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          25       25           
  Lines        3822     3822           
=======================================
  Hits         3639     3639           
  Misses        183      183           
Impacted Files Coverage Δ
mne_bids/path.py 97.67% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoechenberger
Copy link
Member

hoechenberger commented Aug 26, 2022

Looks good, but can we preprend the items with some nice emojis?

  • bug: 🐛 or 🐞
  • feature request: 🛠
  • forum: 💬
  • BIDS spec: 📖

Also I'd add tags instead of preprending the titles. Like, add a bug label instead of disfiguring the title of an issue with [BUG].

Edit: I see we already add labels. So then I'd simply drop the prefixes.

@hoechenberger hoechenberger merged commit 43b77c9 into mne-tools:main Aug 27, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff!

hoechenberger added a commit to hoechenberger/mne-bids that referenced this pull request Aug 27, 2022
Followup to mne-tools#1056

I think it has a much better effect this way!
hoechenberger added a commit that referenced this pull request Aug 27, 2022
Followup to #1056

I think it has a much better effect this way!
@sappelhoff sappelhoff deleted the forms branch August 27, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: update GH issue/pr templates to new features
2 participants