Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Compat with MNE 1.8 birthday date #1278

Merged
merged 6 commits into from
Jul 19, 2024
Merged

MAINT: Compat with MNE 1.8 birthday date #1278

merged 6 commits into from
Jul 19, 2024

Conversation

larsoner
Copy link
Member

  1. Fix compat with MNE 1.8+
  2. Require pytest>=8 (tests will fail on < 8)
  3. Add --fix to autofix stuff like import order on attempted commit (saves time, follows MNE)
  4. Add another warning skip that I got on matplotlib locally

@larsoner larsoner mentioned this pull request Jul 18, 2024
Merged
@larsoner
Copy link
Member Author

Needs mne-tools/mne-python#12732 then should be green 🤞

sappelhoff
sappelhoff approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

@sappelhoff sappelhoff enabled auto-merge (squash) July 18, 2024 05:59
@larsoner
Copy link
Member Author

larsoner commented Jul 18, 2024 •
edited
Loading

Failures are due to sphinx-doc/sphinx#12589. I changed a bunch of autolink refs to explicit refs but couldn't find the last two. So for now I added a !=7.4 which can be removed (or made more specific but it will be annoyingly long) once 7.4.7 comes out. long != list for the likely problematic versions.

@sappelhoff sappelhoff merged commit af12bc4 into mne-tools:main Jul 19, 2024
20 checks passed
@larsoner larsoner deleted the date branch July 19, 2024 01:12
sappelhoff
sappelhoff reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes and for reporting this at the sphinx issue!

.circleci/config.yml
name: Check sphinx log for warnings (which are treated as errors)
when: always
command: |
! grep "^.*WARNING: .*$" sphinx_log.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks!

This was referenced Jul 23, 2024
Closed
Merged
@bootstrapbill bootstrapbill mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsoner @sappelhoff