-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try fixed-width social icons on website #12565
Conversation
The docs are wrong about the default, it seems. Default is the "button that looks like a field and shows the shortcut" AKA the "search field".
It did work in the sense that now on the PR build you have both the search pseudo-field and also the standalone magnifying glass. But where it should go is not |
While I'm at it, does anyone have a suggestion for nicer secondary(?) colors (when you hover over links and the search box outline)? Currently, it's violet/purple in both light and dark themes. We could use colors from our Discourse website ( |
Cf. #12228 (comment) lot of accessibility expertise went into creating the theme's color palette. I'm definitely open to some customization to make it more distinct / MNE-branded, but not at the expense of the a11y guidelines. Can you open a new issue to specifically discuss overrides to the theme's color palette? |
for more information, see https://pre-commit.ci
OK, this is ready, let's discuss color palette changes and other things mentioned in #12558 in separate issues/PRs. |
+1 on this! 👍 |
Quick question, when will these changes be visible on the dev version of mne.tools? Is there some cron job which regularly updates it, or are changes pushed/pulled and I forgot to do that here? |
There's a daily cron job that runs "overnight" w.r.t. the time zones of most of our devs (I forget exactly when) |
This fixes the width of all social icons to 25px (previously, only the Discord icon was 25px wide, whereas the other icons were 18px wide). I'm also removing the Twitter (X) social icon to increase horizontal space in the navbar. Finally, I've moved the GitHub logo all the way to the right to make it stand out more.