Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gotest.tools to v3.4.0 to drop pkg/errors dependency #28

Closed
wants to merge 1 commit into from

Conversation

pacoxu
Copy link

@pacoxu pacoxu commented Jan 12, 2023

Signed-off-by: Paco Xu paco.xu@daocloud.io

See more in kubernetes/kubernetes#114942

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu
Copy link
Author

pacoxu commented Jan 12, 2023

/cc @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we can probably get rid of the gotest.tools package altogether; it looks like it's only used for basic assertions; I'll have a look at a follow-up 👍

@thaJeztah
Copy link
Member

@dims PTAL

@thaJeztah
Copy link
Member

LOL, looks like I already had a branch doing so, but I see the last commit was "WIP";

git checkout -b remove_gotest_tools
fatal: a branch named 'remove_gotest_tools' already exists

git checkout remove_gotest_tools
git log --pretty=format:"%h%x09%an%x09%ad%x09%s"
80e9796 Sebastiaan van Stijn    Thu Mar 12 13:41:45 2020 +0100  WIP remove gotest.tools dependency
c3ff14e Sebastiaan van Stijn    Thu Mar 12 12:28:01 2020 +0100  remove unneeded _windows.go file
a43b11e Sebastiaan van Stijn    Thu Mar 12 12:14:19 2020 +0100  cleanup "ignore" files
860c90c Sebastiaan van Stijn    Thu Mar 12 12:11:56 2020 +0100  Remove testutils package

@thaJeztah
Copy link
Member

I opened #29 as alternative

@dims
Copy link
Collaborator

dims commented Jan 12, 2023

@pacoxu let's use the other one - #29 as it drops 2 packages completely

@pacoxu
Copy link
Author

pacoxu commented Jan 13, 2023

close in favor of #29

@pacoxu pacoxu closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants