-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gotest.tools dependency #29
Conversation
thaJeztah
commented
Jan 12, 2023
•
edited
Loading
edited
- alternative to / closes upgrade gotest.tools to v3.4.0 to drop pkg/errors dependency #28
- relates to Umbrella issue: github archived dependencies (2023 Jan) kubernetes/kubernetes#114942
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
8a1e7e9
to
7ec5809
Compare
I prefer this as we completely eliminate 2 packages (as opposed to the PR #28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yup, same. Also eyeing logrus, but it appears to be used in quite a few places, so perhaps that's for a later concern. I do want to have a quick look at;
|
@cpuguy83 PTAL 🤗 |
Great work. |