-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup host discovery #2509
Cleanup host discovery #2509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more occurrence of github.com/docker/docker/pkg/discovery
needs to be removed
$ ack pkg/discovery vendor/github.com/docker/libnetwork/
vendor/github.com/docker/libnetwork/config/config.go
8: "github.com/docker/docker/pkg/discovery"
will review this once the moby counterpart PR is green since most swarm tests are present there |
d5b7275
to
d530ef9
Compare
Thanks for looking into this; so I'd be interested to see if we still require |
d34d1a3
to
53d79e6
Compare
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
e116439
to
77c3796
Compare
Note we have migrated this codebase over to github.com/moby/moby/libnetwork. |
closing this one; this has been merged in moby through moby/moby#42247 |
Signed-off-by: Anca Iordache anca.iordache@docker.com
relates to moby/moby#40383