Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup host discovery #2509

Closed

Conversation

aiordache
Copy link

@aiordache aiordache commented Feb 19, 2020

Signed-off-by: Anca Iordache anca.iordache@docker.com
relates to moby/moby#40383

Copy link

@eunomie eunomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more occurrence of github.com/docker/docker/pkg/discovery needs to be removed

$ ack pkg/discovery vendor/github.com/docker/libnetwork/
vendor/github.com/docker/libnetwork/config/config.go
8:      "github.com/docker/docker/pkg/discovery"

@arkodg
Copy link
Contributor

arkodg commented Feb 21, 2020

will review this once the moby counterpart PR is green since most swarm tests are present there

controller.go Outdated Show resolved Hide resolved
controller.go Show resolved Hide resolved
@aiordache aiordache force-pushed the libnetwork_rm_node_discovery branch 2 times, most recently from d5b7275 to d530ef9 Compare March 3, 2020 10:08
@thaJeztah
Copy link
Member

Thanks for looking into this; so I'd be interested to see if we still require libkv (and if we could get rid of the dependencies for external k/v stores). I see boltdb is also used through the k/v store (and think we still use that, but not sure 😓). Here's a quick attempt to see what happens if we remove some of the code related to external k/v drivers; #2521

Signed-off-by: Anca Iordache <anca.iordache@docker.com>
@cpuguy83
Copy link
Member

Note we have migrated this codebase over to github.com/moby/moby/libnetwork.
We are not accepting PR's on this repo anymore except for backports to be included in moby 20.10

@thaJeztah
Copy link
Member

closing this one; this has been merged in moby through moby/moby#42247

@thaJeztah thaJeztah closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants