[do not merge] remove "discovery" options #2521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Mar 3, 2020
| "github.com/docker/libnetwork/datastore" | ||
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| func registerKVStores() { | ||
| consul.Register() | ||
| zookeeper.Register() | ||
| etcd.Register() | ||
| boltdb.Register() |
There was a problem hiding this comment.
So, looking at these; I think boltdb is still used, but I'm not sure; wondering if @arkodg knows more about what of this we can all remove
There was a problem hiding this comment.
ya AFAIK we use boltdb for local drivers such as bridge
Closed
thaJeztah
force-pushed
the
libnetwork_rm_node_discovery_cleanup
branch
2 times, most recently
from
ecee054
to
7c0dde3
Compare
thaJeztah
force-pushed
the
libnetwork_rm_node_discovery_cleanup
branch
from
7c0dde3
to
f1fbd15
Compare
thaJeztah
force-pushed
the
libnetwork_rm_node_discovery_cleanup
branch
from
f1fbd15
to
370ef88
Compare
thaJeztah
changed the title
This was referenced Apr 2, 2021
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
libnetwork_rm_node_discovery_cleanup
branch
from
ccd32e6
to
f1391bf
Compare
|
closing this one; this has been merged in moby through moby/moby#42247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry of #2509
Relates to moby/moby#40383
Relates to moby/moby#42247