Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] TestPluginTrustedInstall #31724

Closed
vdemeester opened this issue Mar 10, 2017 · 4 comments · Fixed by #31905
Closed

[Flaky Test] TestPluginTrustedInstall #31724

vdemeester opened this issue Mar 10, 2017 · 4 comments · Fixed by #31905

Comments

@vdemeester
Copy link
Member

DockerTrustSuite.TestPluginTrustedInstall tends to be flaky on janky and experimental.

01:48:39 ----------------------------------------------------------------------
01:48:39 FAIL: docker_cli_plugins_test.go:302: DockerTrustSuite.TestPluginTrustedInstall
01:48:39 
01:48:39 docker_cli_plugins_test.go:320:
01:48:39     c.Assert(err, checker.IsNil)
01:48:39 ... value *errors.errorString = &errors.errorString{s:"\nCommand: /go/src/github.com/docker/docker/bundles/17.04.0-dev/binary-client/docker plugin enable 127.0.0.1:5000/dockercli/trusted-plugin-install:latest\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: error setting up propagated mount dir: invalid argument\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n"} ("\nCommand: /go/src/github.com/docker/docker/bundles/17.04.0-dev/binary-client/docker plugin enable 127.0.0.1:5000/dockercli/trusted-plugin-install:latest\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: error setting up propagated mount dir: invalid argument\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n")
01:48:39 
01:49:02 
01:49:02 ----------------------------------------------------------------------

/cc @anusha-ragunathan @tiborvass @vieux

@anusha-ragunathan
Copy link
Contributor

https://github.com/docker/docker/blob/master/plugin/manager_linux.go#L53 errors due to mount --make-rshared throwing "invalid argument". It is flaky given that regular plugin installs (not trusted) works and even this test on CI passes majority of the time.

@anusha-ragunathan
Copy link
Contributor

anusha-ragunathan commented Mar 10, 2017

Not sure if this is specific to a host. I found only one occurrence of this failing test on Docker-PRs CI. https://jenkins.dockerproject.org/job/Docker-PRs-experimental/31517/console

@vdemeester : Can you provide links to other failures, so we can see if there's a common host symptom?

@thaJeztah
Copy link
Member

@anusha-ragunathan
Copy link
Contributor

@thaJeztah : I think the fix I have will work for this issue. Once the PR is merged, lets wait atleast a week to ensure there are no more test failures on CI (I couldnt reproduce the issue locally)

@thaJeztah thaJeztah added this to the 17.05.0 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants