Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setting up Vagrant-docker with the remote API #2357

Merged
merged 1 commit into from
Nov 29, 2013

Conversation

ucarion
Copy link
Contributor

@ucarion ucarion commented Oct 23, 2013

Hi,

I was having trouble setting up the remote HTTP API on my machine and I previously opened an issue asking how to set this up. In this PR I document what @pyotr777 explained in #2280.

I absolutely had no idea where to document this other than to put it in contrib/vagrant as recommended by @shykes, so if I did this wrong I'll be happy to amend this PR.

Closes #2280

@tianon
Copy link
Member

tianon commented Oct 23, 2013

This LGTM, but I'd want @mzdaniel to take a look at it, because I'm not at all familiar with Vagrant. :)

@ucarion
Copy link
Contributor Author

ucarion commented Oct 23, 2013

I've revised my PR as @donpinkster pointed out that I said a few things about Docker that weren't true in the general case.

I think that having people modify the Vagrantfile to have those SSH ports forwarded is not the easiest way to get things working, so I haven't mentioned that.

@ucarion
Copy link
Contributor Author

ucarion commented Oct 27, 2013

Is this good to merge?

@pyotr777
Copy link

Thanks for summarizing it up.
As for me, I am not sure if it is correct to say about IP 127.0.0.1 concerning initial (default) Docker behavior. Reading the manual here (http://docs.docker.io/en/latest/api/docker_remote_api/) makes me think Docker uses a Unix Domain Socket which is not a network socket and is not associated with any particular IP address. But I could be wrong.

Except for that, the text looks good to me.

@ucarion
Copy link
Contributor Author

ucarion commented Oct 27, 2013

@pyotr777 Seeing as I really don't understand where Docker is looking for things by default, I instead just removed that last part altogether. Thanks for the feedback.

@creack
Copy link
Contributor

creack commented Nov 5, 2013

/cc @metalivedev @mzdaniel

@metalivedev
Copy link
Contributor

Doesn't setting FORWARD_DOCKER_PORTS=1 work for you? I still see it in the Vagrantfile.

@vieux
Copy link
Contributor

vieux commented Nov 11, 2013

FORWARD_DOCKER_PORTS only redirects ports > 49000 (the ports generated randomly by docker)
My the solution woudb be to update the vagrantfile to add 4243 with FORWARD_DOCKER_PORTS ?

@crosbymichael
Copy link
Contributor

@ulyssecarion Can you please rebase?

ping @mzdaniel

@ucarion
Copy link
Contributor Author

ucarion commented Nov 28, 2013

@crosbymichael Does it look good now? There was a merge conflict, so I just appended my modifications to the stuff that was added since I made this PR.

@crosbymichael
Copy link
Contributor

LGTM

ping @vieux I think we can merge this if it looks fine to you

@vieux
Copy link
Contributor

vieux commented Nov 29, 2013

LGTM I'll let @metalivedev decide

@crosbymichael
Copy link
Contributor

@vieux it's in contrib

vieux pushed a commit that referenced this pull request Nov 29, 2013
Document setting up Vagrant-docker with the remote API
@vieux vieux merged commit ff57477 into moby:master Nov 29, 2013
cpuguy83 pushed a commit to cpuguy83/docker that referenced this pull request May 25, 2021
Print proper error log when peerAdd fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how to be able to connect to the Docker API when using Vagrant?
7 participants