-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document setting up Vagrant-docker with the remote API #2357
Conversation
This LGTM, but I'd want @mzdaniel to take a look at it, because I'm not at all familiar with Vagrant. :) |
I've revised my PR as @donpinkster pointed out that I said a few things about Docker that weren't true in the general case. I think that having people modify the Vagrantfile to have those SSH ports forwarded is not the easiest way to get things working, so I haven't mentioned that. |
Is this good to merge? |
Thanks for summarizing it up. Except for that, the text looks good to me. |
@pyotr777 Seeing as I really don't understand where Docker is looking for things by default, I instead just removed that last part altogether. Thanks for the feedback. |
Doesn't setting |
|
@ulyssecarion Can you please rebase? ping @mzdaniel |
@crosbymichael Does it look good now? There was a merge conflict, so I just appended my modifications to the stuff that was added since I made this PR. |
LGTM ping @vieux I think we can merge this if it looks fine to you |
LGTM I'll let @metalivedev decide |
@vieux it's in contrib |
Document setting up Vagrant-docker with the remote API
Print proper error log when peerAdd fails
Hi,
I was having trouble setting up the remote HTTP API on my machine and I previously opened an issue asking how to set this up. In this PR I document what @pyotr777 explained in #2280.
I absolutely had no idea where to document this other than to put it in contrib/vagrant as recommended by @shykes, so if I did this wrong I'll be happy to amend this PR.
Closes #2280