seccomp: add pidfd syscalls #41665
Merged
seccomp: add pidfd syscalls #41665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikroskeem
changed the title
Signed-off-by: Mark Vainomaa <mikroskeem@mikroskeem.eu>
mikroskeem
force-pushed
the
41664-pidfd-syscalls-support
branch
2 times, most recently
from
013520e
to
e5e238b
Compare
AkihiroSuda
reviewed
Nov 11, 2020
AkihiroSuda
added
area/security/seccomp
kind/enhancement
mikroskeem
force-pushed
the
41664-pidfd-syscalls-support
branch
from
e5e238b
to
fd41ae9
Compare
|
@justincormack PTAL |
|
Should I also create a separate PR against |
Changes to the 19.03 branch are backported / cherry-picked after a PR is merged on master. (Also wanting to wait for review, and to discuss if this change is "safe" to backport to 19.03, as docker 20.10 is imminent, and 19.03 is quite late in its support cycle). If this PR is accepted/merged, a PR should likely be opened in the containerd repository as well, to update the seccomp-profile accordingly |
Signed-off-by: Mark Vainomaa <mikroskeem@mikroskeem.eu>
mikroskeem
force-pushed
the
41664-pidfd-syscalls-support
branch
from
fd41ae9
to
f7bcb02
Compare
justincormack
approved these changes
Nov 13, 2020
This was referenced Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added
pidfd_{getfd, open, send_signal}syscalls into default seccomp profile, closes issue #41664.- How I did it
By adding syscall names into the json file.
- How to verify it
See docker/for-linux#1142 reproduction steps.
- Description for the changelog
Add support for pidfd_* syscalls into default seccomp profile. Closes #41664
- A picture of a cute animal (not mandatory but encouraged)
Maybe this Bernese Mountain Dog will do