scheduler: Correctly count tasks at bottom level of decision tree #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each node in the decision tree has a count of tasks assigned at or below that node. The bottom level did not have this count populated. Fix this so that topology-aware scheduling works correctly when tasks are scheduled individually. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
- Coverage 53.74% 53.71% -0.04%
==========================================
Files 109 109
Lines 19194 19196 +2
==========================================
- Hits 10316 10311 -5
+ Misses 7631 7626 -5
- Partials 1247 1259 +12Continue to review full report at Codecov.
|
Merged
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each node in the decision tree has a count of tasks assigned at or below
that node. The bottom level did not have this count populated. Fix this
so that topology-aware scheduling works correctly when tasks are
scheduled individually.
Test coverage for this is coming in the next PR.
cc @dongluochen