[17.09] Increase gRPC request timeout to 20 seconds when sending snapshots #2404
Conversation
nishanttotla
force-pushed
the
increase-grpc-timeout-17.09
branch
from
32c6678 to
06497c4
Compare
Signed-off-by: Nishant Totla <nishanttotla@gmail.com> (cherry picked from commit e3e2821) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
increase-grpc-timeout-17.09
branch
from
06497c4 to
b6e7720
Compare
|
@abhi I remember your PR had some vendoring issues like this one is having. Can you tell me what the fix was? |
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Codecov Report
@@ Coverage Diff @@
## bump_v17.09 #2404 +/- ##
===============================================
+ Coverage 60.22% 60.28% +0.05%
===============================================
Files 128 128
Lines 26154 26167 +13
===============================================
+ Hits 15751 15774 +23
+ Misses 9025 9007 -18
- Partials 1378 1386 +8 |
|
Okay doing a vndr update and rerunning vndr seems to have fixed the CI. Ping @anshulpundir @dperny |
There was a problem hiding this comment.
There are some readme files updated. Is this expected ? @nishanttotla
|
@anshulpundir it's because I reran |
|
@andrewhsu can you confirm that this is okay to do? |
|
Yes; recent versions of vndr include readme's, because they often state licensing information |
|
Perhaps worth having something similar as in the moby/moby repo, where we pin to a specific version of vndr to make sure the vendoring is always done with the same version; https://github.com/moby/moby/blob/842bbeb63d82a55ee6ce537f860e9b37c146481c/hack/dockerfile/install-binaries.sh#L156 |
|
|
Cherry-pick #2391
git cherry-pick -s -x e3e2821fe3eae707915b78215526da078d2d75a7Cherry-pick was clean.