Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] Increase gRPC request timeout to 20 seconds when sending snapshots #2405

Merged

Conversation

nishanttotla
Copy link
Contributor

Cherry-pick #2391

git cherry-pick -s -x e3e2821fe3eae707915b78215526da078d2d75a7

Cherry-pick was clean.

Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
(cherry picked from commit e3e2821)
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
@nishanttotla
Copy link
Contributor Author

Ping @andrewhsu @thaJeztah @anshulpundir

@nishanttotla nishanttotla changed the title Increase gRPC request timeout to 20 seconds when sending snapshots [17.06] Increase gRPC request timeout to 20 seconds when sending snapshots Oct 11, 2017
@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #2405 into bump_v17.06 will decrease coverage by 0.05%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v17.06    #2405      +/-   ##
===============================================
- Coverage        59.82%   59.77%   -0.06%     
===============================================
  Files              120      120              
  Lines            25093    25106      +13     
===============================================
- Hits             15011    15006       -5     
- Misses            8748     8760      +12     
- Partials          1334     1340       +6

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishanttotla nishanttotla merged commit b66cd76 into moby:bump_v17.06 Oct 18, 2017
@nishanttotla nishanttotla deleted the increase-grpc-timeout-17.06 branch October 18, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants