Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slirp is not parsing properly thealiases from the host's /etc/hosts #162

Closed
rogaha opened this issue Nov 25, 2016 · 0 comments
Closed

slirp is not parsing properly thealiases from the host's /etc/hosts #162

rogaha opened this issue Nov 25, 2016 · 0 comments
Labels

Comments

@rogaha
Copy link

rogaha commented Nov 25, 2016

Expected behavior

The aliases should be taken into account when retrying to resolve the DNS queries.

Actual behavior

The aliases are not working as expected, only the the first hostname is resolved properly. See an example below:

rogaha@Robertos-MacBook-Pro:~$ cat /etc/hosts | grep moby                                                                                                                  10:34:49
127.0.0.1   localhost moby
rogaha@Robertos-MacBook-Pro:~$ curl -I moby:5000                                                                                                                           10:34:55
HTTP/1.1 200 OK
Cache-Control: no-cache
Date: Fri, 25 Nov 2016 10:34:59 GMT
Content-Type: text/plain; charset=utf-8
----- from moby
/ # curl -I moby:5000
curl: (6) Couldn't resolve host 'moby'
----- from container
root@5202c482d996:/# curl -I moby:5000
curl: (6) Could not resolve host: moby
@rogaha rogaha added the bug label Nov 25, 2016
djs55 added a commit to djs55/vpnkit that referenced this issue Jan 11, 2017
Tests: moby#162

Signed-off-by: David Scott <dave.scott@docker.com>
djs55 added a commit to djs55/vpnkit that referenced this issue Jan 11, 2017
Previously if a line in /etc/hosts contained

  127.0.0.1 localhost mylocalhost

we would fail to parse the line. This patch parses the line and will
add `localhost` and `mylocalhost` as mappings.

Fixes moby#162

Signed-off-by: David Scott <dave.scott@docker.com>
djs55 added a commit to djs55/vpnkit that referenced this issue Jan 11, 2017
Tests: moby#162

Signed-off-by: David Scott <dave.scott@docker.com>
@djs55 djs55 closed this as completed in f89a79c Jan 11, 2017
avsm pushed a commit to avsm/vpnkit that referenced this issue May 5, 2017
Add GitHub integration to client API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant