Close partially-established TCP connections #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client sends SYN, we connect the external socket and reply with SYN ACK. If the client responds with RST ACK then previously we would leak the connection. This patch refactors the connection closing mechanism, creating an idempotent `close_flow` function which is called - on normal close when the proxy receives `FIN` etc - on a reset, including during the handshake - when a switch port is being timed-out. This replaces the previous `on_destroy` promise which was used in `Lwt.pick` since closing the connection should cause the proxy to receive EOF. Related to [docker/for-mac#1132] Signed-off-by: David Scott <dave.scott@docker.com>
This is needed because we don't support the keepalive stuff. Signed-off-by: David Scott <dave.scott@docker.com>
This fixes the build probably broken by a jbuilder upgrade. Signed-off-by: David Scott <dave.scott@docker.com>
In particular the archives of ppx_import, a test dependency of uwt are missing. In future we will manually reference the test dependencies of the packages that we actually want to test. Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
`opam install vpnkit -t` will install the test dependencies of our dependencies, some of which don't exist (ppx_import) This patch manually installs dependencies used by vpnkit. Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client sends SYN, we connect the external socket and reply with SYN ACK. If the client responds with RST ACK then previously we would leak the connection.
This patch refactors the connection closing mechanism, creating an idempotent
close_flowfunction which is calledFINetcThis replaces the previous
on_destroypromise which was used inLwt.picksince closing the connection should cause the proxy to receive EOF.Related to [docker/for-mac#1132]
Signed-off-by: David Scott dave.scott@docker.com