resolves #1300: passing 0 to timeout() will disable timeouts

[boneskull]

After 5dad9a3, it seems this.timeout(0) stopped working.

I re-enabled it inasmuch as I understood how it works, and added a test.

I was unsure whether or not @travisjeffery had intended to change the API, so that's why this is a PR.

[ksmithut]

Any word on getting this merged? All my tests broke because of this timeout issue. I can set just a high timeout, but I prefer setting it to 0.

[ksmithut]

@boneskull thanks!

[ksmithut]

@boneskull this didn't seem to work....

describe('Mocha Test', function () {
  before(function (done) {
    this.timeout(0);
    setTimeout(done, 5000);
  });
  describe('sub tests', function () {
    it('should do something awesome', function () {
      return;
    });
  });
});

The above test when run with the new version of mocha still breaks with a timeout of 2000ms exceeded.

[travisjeffery]

iirc before never supported this

[ksmithut]

@travisjeffery it worked until just recently. If it's not meant to be supported, that's fine, but the documentation should be updated if that's the case.

[boneskull]

@ksmithut: has not been released yet. did you try from master? just got merged.

On Aug 6, 2014, at 13:23, ksmithut notifications@github.com wrote:

@boneskull this didn't seem to work....

describe('Mocha Test', function () {
before(function (done) {
this.timeout(0);
setTimeout(done, 5000);
});
describe('sub tests', function () {
it('should do something awesome', function () {
return;
});
});
});
The above test run with the new version of mocha still breaks.

—
Reply to this email directly or view it on GitHub.

[ksmithut]

Ah, I saw the package get published soon after this pull request was merged in (or close around), so I assumed it was included in the publish to 1.21.4. I'll give it another try.