Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extremely slow diff report with buffers #1433

Closed
t1bb4r opened this issue Nov 15, 2014 · 3 comments
Closed

Extremely slow diff report with buffers #1433

t1bb4r opened this issue Nov 15, 2014 · 3 comments
Assignees
@boneskull

Comments

@t1bb4r
Copy link

t1bb4r commented Nov 15, 2014

mocha version 1.21.5

Comparing Buffers take too long. assert fails instantly, where mocha uses so many resources that my computer crashes.

This has become a problem since mongoose ObjectId's use Buffers, and if two Id's are not the same instead of test failing, our test suite freezes.

https://gist.github.com/t1bb4r/407d88178686b7471911
@dasilvacontin
Copy link
Contributor

Probably related to #1132.

@boneskull
Copy link
Contributor

Yeah, the behavior changed recently.

@boneskull
Copy link
Contributor

geez, I thought #1132 was merged. sorry. I'll take a look this evening.

@boneskull boneskull self-assigned this Nov 17, 2014
tandrewnichols pushed a commit to tandrewnichols/mocha that referenced this issue Dec 15, 2014
@a8m @tandrewnichols
Fix buffer diffs (closes mochajs#1132, closes mochajs#1433)
267aabe
@astorije astorije mentioned this issue Mar 24, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boneskull boneskull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boneskull @dasilvacontin @t1bb4r