-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grep links for test names with dots "." don't get escaped correctly. #2070
Comments
Upstream mocha bug is escaping '.' too aggressively mochajs/mocha#2070 Fixes #282 Fix grep again
Thanks! That definitely fixes it. 👍 :-) |
The same problem reared its head again in WebComponentTester. Not sure what changed in mocha to add it back in, but just wanted to let you all know. |
👋 @btelles I'm not familiar with WebComponentTester and don't see a straightforward way to reproduce this in the latest versions of Polymer. I know it's been a few years, but are you able to provide a standalone reproduction for this issue? No worries if not - just wanted to check in in case you're still hopeful for a resolution! (for context on why you're only now getting pinged, see #5027) |
Closing out old issues. If someone does have a repro, please do post back - we'd be happy to take a look! 🤎 |
Steps to Reproduce:
Expected result:
Link reduces the tests to be run to those inside crud-behavior-basic.html file.
Generated link has: grep=crud-behavior-basic.html
Actual result:
No tests are run.
Generated link has: grep=crud-behavior-basic%5C.html
Related bug: #1687
Related PR: #1698
It appears the following line of code is overzealous. Replacing the . with %5C
https://github.com/benvinegar/mocha/commit/3166e701a356d472656878ae78e5b819099f95d9#diff-998e3fb668a2094eedccab3e56199e4fR204
The text was updated successfully, but these errors were encountered: