Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated header anchor links on mouseover #3714

Closed
boneskull opened this issue Feb 4, 2019 · 6 comments · Fixed by #3850
Closed

duplicated header anchor links on mouseover #3714

boneskull opened this issue Feb 4, 2019 · 6 comments · Fixed by #3850
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@boneskull
Copy link
Contributor

  1. Go to https://next.mochajs.org
  2. Mouseover a heading

image

Remove the #; keep the other one.

cc @Munter
@boneskull boneskull added type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! labels Feb 4, 2019
@cjdeleon62
Copy link

@boneskull @Munter mind if I take this issue?

@boneskull
Copy link
Contributor Author

sure. npm start docs to build docs, see docs/_dist/index.html for result

@Munter
Copy link
Contributor

Munter commented Feb 5, 2019

Is this still a thing? I thought I fixed that one. If it's still a problem it might be related to the markdown auto header linking functionality

@cjdeleon62
Copy link

@Munter does not seem like it's an issue anymore, so I think you must have fixed it 😃

@outsideris
Copy link
Contributor

I think it fixed.

jd2rogers2 added a commit to jd2rogers2/mocha that referenced this issue Mar 27, 2019
@jd2rogers2
Remove pound icon showing on header hover on docs mochajs#3714
f26be9d
@jd2rogers2 jd2rogers2 mentioned this issue Mar 27, 2019
Merged
@jd2rogers2
Copy link
Contributor

i am still seeing the issue so put in a fix (my first, so def open to feedback)
however, if no one else is seeing it maybe this should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pound icon showing on header hover on docs #3714 jd2rogers2/mocha
5 participants
@Munter @outsideris @boneskull @cjdeleon62 @jd2rogers2