--watch and .only conflict

[rstacruz]

Using it.only() with --watch yields unexpected results.

Steps:

1. Run mocha --watch on your huge test suite
2. Watch as how it runs 1,000 tests
3. Mark one of those tests as it.only
4. Watch as how it now runs just 1 test
5. Now change back the it.only(...) to it(...)

Expected: run 1,000 tests
Actual: still running just one test

[faridnsh]

I just experienced this...

[tj]

ugh.... really want to remove --watch

[benjamine]

what do you suggest instead? using another tool like grunt,js watch?

[faridnsh]

@benjamine I use nodemon for things that don't have a watch support. Works great. There's also node-supervisor.

[benjamine]

yes, I suppose some could get furious, but I agree --watch should deprecate.
To make it less traumatic someone could create a mocha-watch package by simply combining mocha and nodemon,
(that would allow integration with other apps, IDEs, notifiers, to move to that project)

[onetom]

I just hit the same issue. I was using the https://github.com/alexch/rerun project but it was noticing the file changes very slowly, that's why i though i give a try to mocha -w
Trying nodemon now, but is there any new recommendation on this topic?

[startswithaj]

The main issue here was that the global mocha.grep gets set to the title of the .only test. And then once you remove the .only test the mocha.grep remains set to the title. This fix simply resets the grep on rerun() which is the function --watch uses.

[startswithaj]

My initial PR didn't cover the scenario where you pass in a grep option via --grep and on rerun() it would get cleared. Now if you pass in a grep via --grep, mocha.grep is not cleared however greps created via .only() are.

[Guuz]

Having the same issue...