Improve error output when a test fails with a non-error #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
dasilvacontin
added a commit
that referenced
this pull request
Feb 6, 2015
Improve error output when a test fails with a non-error
| @@ -197,6 +199,8 @@ Runner.prototype.fail = function(test, err){ | |||
|
|
|||
| if ('string' == typeof err) { | |||
| err = new Error('the string "' + err + '" was thrown, throw an Error :)'); | |||
| } else if (!(err instanceof Error)) { | |||
| err = new Error('the ' + type(err) + ' ' + stringify(err) + ' was thrown, throw an Error :)'); | |||
There was a problem hiding this comment.
Why is there a second branch of the conditional here? Why not just remove the check for string, and simply display this message if err is not an Error?
There was a problem hiding this comment.
True. Sorry, missed that.
There was a problem hiding this comment.
Thanks @boneskull PR #1542 submitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #1532