fix(reporter/base): explicitly ignore showDiff #1614

[a8m]

Ignore showDiff only if it's explicitly set to false.
see #1614 , #810

[danielstjules]

🎉

Also, those specs are a perfect example of why we should fix #1582 If Base.list failed, process.stdout.write wouldn't be restored. And we can't just do it from afterEach because then the reporter won't print the spec at all. I'm gonna tackle that tonight. :)

[mantoni]

Thanks @a8m 👍

[dasilvacontin]

LGTM.

[dasilvacontin]

thanks guys!

[a8m]

Thanks @dasilvacontin

[dominicbarnes]

Awesome! Was just wondering about this and glad to see it's been addressed. How long until a release?

[dasilvacontin]

Euh, best way to force a sooner release is to make the releasers aware of the need. 😄

/cc @travisjeffery @boneskull